Fantastic console for the money
This is a great console for the money. The performance upgrade and graphical upgrade from the xbox one S is definitely worth it. I own both the PS4 Pro and The Xbox one X and love both consoles for different reasons. Ignore those who trash one over the other.
Xbox one X
Pros - Best looking graphics of any console, speed, Xbox live, best for cross platform games.
Cons - lack of top tier exclusives. internal storage not upgradeable. Most expensive console.
Pros - Amazing exclusive games, excellent graphics, internal storage can be easily upgraded to a larger hard drive or SSD.
Cons - Not as powerful as Xbox One X.
Things to consider:
If you can afford to buy both just do it and you wont regret it. If you have to pick just one then you may be better off buying the PS4 Pro only because the performance is still good for cross platform games and you get access to the Top Tier exclusives as well as upgradeability for the internal hard drive. Now if you currently own a One S with a large library of games and are looking to upgrade, then that changes things and your probably better off buying the One X.
Like I said I like I said earlier I like both machines for different reasons. They're both excellent and those know need to trash one over the other.